Add CreationFailure exit code

[goughes]

Fixes #9531

Status

Not tested

Description

Add a missing exit code to WMExceptions.py:

99305: "Found single input file with too many events to be processed in a pilot lifetime"

Is it backward compatible (if not, which system it affects?)

YES

Related PRs

NA

External dependencies / deployment changes

NA

[goughes]

@amaltaro Any need to update the defaultMsg here to reflect the new message I put in WMExceptions?

WMCore/src/python/WMComponent/JobCreator/JobCreatorPoller.py

Line 738 in bd40c3e

defaultMsg = "There is a condition which assures that this job will fail if it's submitted"

[cmsdmwmbot]

Jenkins results:

• Unit tests: succeeded
• Pylint check: succeeded
  • 3 comments to review
• Pycodestyle check: succeeded
  • 8 comments to review
• Python3 compatibility checks: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/9733/artifact/artifacts/PullRequestReport.html

[amaltaro]

Interesting, I'm curious to know what that condition would be. Could you please try to find where it's supposed to get triggered? Otherwise it makes sense to me to also update that default msg.

[goughes]

@amaltaro I looked around for a case where failedReason would not be set when creating a failed job. No guarantees my search was exhaustive, but 30 mins seemed like enough time to spend tracing where this can be set.

Hence, I updated defaultMsg to reflect the error message from the exception.

[cmsdmwmbot]

Jenkins results:

• Unit tests: failed
  • 1 new failures
• Pylint check: failed
  • 1 warnings and errors that must be fixed
  • 4 warnings
  • 11 comments to review
• Pycodestyle check: succeeded
  • 28 comments to review
• Python3 compatibility checks: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/10131/artifact/artifacts/PullRequestReport.html

[cmsdmwmbot]

Jenkins results:

• Unit tests: succeeded
• Pylint check: failed
  • 1 warnings and errors that must be fixed
  • 4 warnings
  • 11 comments to review
• Pycodestyle check: succeeded
  • 28 comments to review
• Python3 compatibility checks: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/10132/artifact/artifacts/PullRequestReport.html

[amaltaro]

Yes, it looks like failedReason is always present on those jobs that failed to be created:
https://github.com/dmwm/WMCore/blob/master/src/python/WMCore/JobSplitting/JobFactory.py#L139

Erik, please request a review via GH Reviewers once you're happy with your changes.

[todor-ivanov]

Looks good to me

[amaltaro]

Thanks Erik! Final test will come before we release the next production WMA release.