Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nose2 to the wmagent requirements file #9778

Merged
merged 1 commit into from
Jun 30, 2020
Merged

Conversation

amaltaro
Copy link
Contributor

Fixes #9777

Status

ready

Description

Added nose2 to the list of python packages that WMAgent depends on.
Library still not used anywhere, only to be shipped with the wmagent-dev docker image.

Is it backward compatible (if not, which system it affects?)

YES

Related PRs

cms-sw/cmsdist#6003

External dependencies / deployment changes

yes, cms-sw/cmsdist#6003

@cmsdmwmbot
Copy link

Jenkins results:

  • Unit tests: succeeded
    • 2 tests no longer failing
    • 6 changes in unstable tests
  • Pylint check: succeeded
  • Pycodestyle check: succeeded
  • Python3 compatibility checks: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/10191/artifact/artifacts/PullRequestReport.html

@amaltaro amaltaro requested a review from goughes June 30, 2020 12:10
Copy link
Contributor

@goughes goughes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amaltaro amaltaro merged commit 75bb696 into dmwm:master Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add nose2 dependency to the WMCore software stack
3 participants