Construct the PU location via rucio considering MSTransferor locks #9930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins results:
|
|
Jenkins results:
|
fix more unit tests
|
Jenkins results:
|
|
@belforte Stefano, I should have implemented it yesterday. But in case it's not too late, I have made 2 useful utilitarian functions in the Rucio wrapper module. Check this PR out if you want. |
|
thanks Alan. Not too late. I will adopt dmwm/CRABServer#6165 |
|
@khurtado FYI, this PR will slightly change the format of our pileupconf.json data structure (FileList will be a flat list, instead of a list of dicts). |
|
Unit test tests most of this functionality, a real test is still required though, once we have more data in Rucio int database |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9894
Status
ready
Description
Previous logic in WMAgent for resolving the pileup location (the pileupconf.json construction) was simply relying on the current block location, without considering who locked the data.
This PR changes that functionality to something similar to what is done at WorkQueue level, such that we only use data that has been locked by MSTransferor.
I also have two somehow unrelated changes here:
FileListwill contain a flat list of file names (instead of {"logical_file_name": })FileListis no longer sorted. I couldn't see any reason to sort it. Besides, at SetupCMSSWPSet level we shuffle all those files..Is it backward compatible (if not, which system it affects?)
no, between old and new agents. But this isn't a valid use case.
Related PRs
none
External dependencies / deployment changes
none