Rucio list parent dids

[germanfgv]

Builds towards fixing #9623

Status

ready

Description

Wrapper for Rucio API's list_parent_dids()

Is it backward compatible (if not, which system it affects?)

YES

Related PRs

As stated in #9933, we need to list parent DIDs for each block

External dependencies / deployment changes

No

[cmsdmwmbot]

Jenkins results:

• Unit tests: succeeded
• Pylint check: failed
  • 1 warnings and errors that must be fixed
  • 12 warnings
  • 6 comments to review
• Pycodestyle check: succeeded
  • 6 comments to review
• Python3 compatibility checks: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/10455/artifact/artifacts/PullRequestReport.html

[amaltaro]

@germanfgv just to make sure we have the correct concept of parent in the context of Rucio.

• a file has a block parent, basically the block which the file belongs to
• a block has a container (or multiple, if we start creating customized containers), basically the container which the block belongs to
  is that correct?

In that case, if I call this API list_parent_dids with a block name. Does it look for all the rules locking the parent container? Or it lists all rules of the parent container AND the rules for this block?

[germanfgv]

@germanfgv just to make sure we have the correct concept of parent in the context of Rucio.

• a file has a block parent, basically the block which the file belongs to
• a block has a container (or multiple, if we start creating customized containers), basically the container which the block belongs to
  is that correct?

In that case, if I call this API list_parent_dids with a block name. Does it look for all the rules locking the parent container? Or it lists all rules of the parent container AND the rules for this block?

list_parent_dids does not look for rules, it looks for parent DIDs. If you call this API with a block name, it will return a list of dictionaries, each one describing a parent container. If you call this API with a file name, it will return a dictionary describing the parent block (not sure if a file can belong to multiple blocks).

In order to list all the rules locking the parent container of a block, I will use listParentDIDs to get the parent container and then use listDataRules to get its rules.

[amaltaro]

Sorry, I don't know how I came up with rules here(!)
Your answer clarifies my question though. Thanks

[germanfgv]

I could have created a method using both list_parent_dids and list_did_rules to directly get the parents's rules, but I decided against that. My reasoning was that being able to list parent DIDs may be useful for other purposes in RucioInjector.py, so I created listParentDIDs. @amaltaro Do you agree with this?

[amaltaro]

@germanfgv code looks good to me. And I agree in separating these APIs for dids and rules too.
I asked a question in the code though, other than that it's good to go from my side.

Actually, I would ask you to implement a unit test for it. But since I'm working on a few other unit tests for this Rucio wrapper, I can take care of that.

[amaltaro]

Thanks German