Add better wildcard file search support #3962
Conversation
valadas
changed the title
There was a problem hiding this comment.
Looks good to me, worked on this with @david-poindexter and it's tested and works much better.
Basically there was wrong escapes and "starts-with" and "ends-with" regex symbols that made no sense in a search context where we need a "contains" behaviour.
Now this does fix the search and let's call that a step 1. But in our findings, this is not awesome for performance in sites with lots of recursive files. Right now the search is enforced as being recursive and the results are filtered in code by a Regex, nothing new, it was like that already.
For performance on large installs, this has 2 problems:
1: Recursive search should be an option and maybe not the default, the code is in place but we would need some little piece of UI to turn the search to actually be recursive...
2: Getting all the files and filtering them in code using a Regex is debatable, I guess the whole results are cached before but well it may very well be that a new file search stored procedure could have better performance ?
At any rate, this is an improvement over what we currently have, just opening a can of worms here for future improvements :)
| @@ -1845,11 +1845,11 @@ private static Regex WildcardToRegex(string pattern) | |||
| { | |||
| if (!pattern.Contains("*") && !pattern.Contains("?")) | |||
| { | |||
| pattern = "^" + pattern + ".*$"; | |||
| pattern = ".*" + Regex.Escape(pattern) + ".*"; | |||
There was a problem hiding this comment.
If you don't have the start and end tokens, you wouldn't need the .* pattern, either, right?
There was a problem hiding this comment.
I too am curious on this one, the "old way" was requires full string match, starting with the pattern at the beginning. For example
TestF as an input
Would match TestF, TestFile, TestFilters, TestF Test, etc
This new pattern would match those, but also would match
MyTestF, etc.
Is this a desired behavior?
There was a problem hiding this comment.
I too am curious on this one, the "old way" was requires full string match, starting with the pattern at the beginning. For example
TestF as an input
Would match TestF, TestFile, TestFilters, TestF Test, etc
This new pattern would match those, but also would match
MyTestF, etc.
Is this a desired behavior?
Yes, this is the desired behavior. It is a much more powerful wildcard search.
There was a problem hiding this comment.
If you don't have the start and end tokens, you wouldn't need the
.*pattern, either, right?
I believe you would in order to achieve the "contains" search results.
There was a problem hiding this comment.
Regular Expression matching is a "contains" match by default, here's an example:
There was a problem hiding this comment.
It looks like this was merged already, so I'll do another PR to change this. Thanks @bdukes
|
I agree, left search is most common and I don't see a need for supporting search in the middle of a word. |
|
Just to be clear, this PR is in support of the new Resource Manager. I should have made that clearer in my initial comments. Notice the PR is against the feature branch. ;-) |
Add better wildcard search support
Item Namesort dropdown