Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup message content changed to avoid plural confusion #3980

Merged
merged 2 commits into from
Aug 28, 2020

Conversation

tauqeer-haider
Copy link
Contributor

Fixes #3979

Summary

The popup message is changed from "Settings has been updated." to "Configuration has been updated." to avoid plural confusion with Settings vs Setting

Copy link
Contributor

@mitchelsellers mitchelsellers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This verbiage now becomes inconsistent with the rest of the messaging/errors.

I think a bigger review is needed

@sleupold
Copy link
Contributor

IMO, configuration or settings are about the same - but either "configuration has been updated" or "settings have been updated".

@v-karbovnichy
Copy link
Contributor

We have a test case in Evoq which was failed by QA executor with comment The message displayed is "Settings has been updated". Failing the execution as this is grammatically wrong.

After that another team member left the comment:

I would make the case here that the actual message is correct and the expected message in the test case is wrong.
"Settings have been updated" means that multiple settings have been updated which is not true here, there was only 1 setting updated which is "Allowable File Extensions".
"Settings has been updated" refers to the settings configuration as a unit, as in the "configuration (settings) has been updated".

And so I made a proposal to fix it this way:

To avoid confusion ("Settings" is treated as plural by non-native English speakers) we can change "Settings" to "Configuration" and leave "has" as-is.

We can decide here to change has -> have to avoid inconsistent verbiage impact with Settings -> Configuration

@mitchelsellers
Copy link
Contributor

After discussion in the approvers meeting,

"Settings have been updated" is a more consistent solution to this verbiage issue and is consistent with the section of the Persona Bar we are working with.

Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@bdukes bdukes added this to the 9.7.1 milestone Aug 28, 2020
@bdukes bdukes merged commit 2d6eb3f into dnnsoftware:develop Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants