Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevents creation of custom registration form without DisplayName and no DisplayNameFormat #4015

Merged
merged 1 commit into from
Aug 28, 2020

Conversation

tauqeer-haider
Copy link
Contributor

@tauqeer-haider tauqeer-haider commented Aug 26, 2020

DNN-41046: disallowed custom form without DisplayName and lacking a DisplayNameFormat

Fixes #3971

Summary

Custom Registration Form without DisplayName field on it and lacking Display Name Format is no longer allowed and considered as incorrect configuration.

@valadas valadas changed the title DNN-41046: disallowed custom form without DisplayName and lacking a D… Disallowed custom form without DisplayName and lacking a DisplayNameFormat Aug 28, 2020
@valadas
Copy link
Contributor

valadas commented Aug 28, 2020

@tauqeer-haider Please do not use external reference number in PR or issue titles as we use titles for the release notes and those references are internal and mean nothing to visitors here. I updated the title and moved your reference number in the description. Thanks.

Copy link
Contributor

@david-poindexter david-poindexter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, this looks good to me - thanks @tauqeer-haider 🎉

@david-poindexter david-poindexter added this to the 9.7.1 milestone Aug 28, 2020
@valadas valadas changed the title Disallowed custom form without DisplayName and lacking a DisplayNameFormat Disallowed creation of custom registration form without DisplayName and lacking a DisplayNameFormat Aug 28, 2020
@valadas valadas changed the title Disallowed creation of custom registration form without DisplayName and lacking a DisplayNameFormat Prevents creation of custom registration form without DisplayName and no DisplayNameFormat Aug 28, 2020
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@valadas valadas merged commit b7e7b16 into dnnsoftware:develop Aug 28, 2020
@tauqeer-haider
Copy link
Contributor Author

@tauqeer-haider Please do not use external reference number in PR or issue titles as we use titles for the release notes and those references are internal and mean nothing to visitors here. I updated the title and moved your reference number in the description. Thanks.

Noted. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User registration fails when Displayname field is not present in the custom register form
3 participants