Fixed bug with hierarchical vocabularies

[daguiler]

Fixes #4047

Summary

Several problems in this findInChildren function.

1. The forEach loop cannot be broken, so the return statement at line 19 was not actually exiting the function.
2. The initial value of parentTerm was an empty object, so if the item was not found, an empty object was being returned by the function. However, empty objects evaluate to true, not to false.
3. Since this is a recursive function, and because of 2), line 21 was deciding to continue instead of deciding to stop. This was causing the parentTerm variable to get incorrectly overwritten in following cycles.

I replaced this buggy function with a more clear implementation that immediately breaks the loop if the item is found, or returns null otherwise.

[bdukes]

Your description states that your new function "immediately breaks the loop if the item is found", but I don't see an immediate return. Other than adding a return, this looks good to me. Thanks!

[daguiler]

Hi @bdukes, the break is in the for condition.

[valadas]

Looks good to me