Fix the web.config errors for the new Localization module #4267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#4264 removed the localization module from the config to start, so there shouldn't be duplicates now. |
|
And I think we still want it to run as early as possible. |
|
I agree with @bdukes here |
|
Yeah I thought it was fixed, at least I don't have duplicates on a clean install from a build on the release branch... @donker was this tested after Brian's PR got merged ? |
|
When I tested, Brian's PR hadn't been merged yet. Now it should be fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately the XmlMerge in DNN does not allow a collision check when doing any other action than "update". This prompted two Localization modules to be present in the web.config for new installs which makes the site unuseable. This PR changes the action to be "update". Note that it means we don't control where in the modules pipeline the module sits. But this has become a moot point since we changed the event order for this module.
In the future we should adjust the XmlMerge class to cater for collision control for the other actions, IMHO.