This repository has been archived by the owner on Jan 20, 2020. It is now read-only.
Merge python3 pull requests, add tests for python3 #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HitkoDev
commented
May 24, 2017
HitkoDev
commented
- closes Fix #7 adding support for Python 3 #14, fix for python3 #16, Added Python 2 and Python 3 compatibility. #29
I have this simple update to get my script working with Python 3. Can anyone clarify this?
Added six and __future__ imports to better compatibility between python2 and python3 environments.
Remove the excessive need of six functions that are not really needed. Fixed up the auth tests.
Fixed the base64.v64encode to return a string and not bytes objects.
Added mock lib for Python2 and reverted the os.envion.get to remove the default kwarg that is not in Python2.
…test as well. All tests pass in both Python2 and Python3 environments.
# Conflicts: # dockercloud/api/auth.py # dockercloud/api/http.py
# Conflicts: # dockercloud/api/http.py
# Conflicts: # tests/test_action.py # tests/test_auth.py
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.