Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multi-line backend extras with line separator || #90

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chrsch
Copy link

@chrsch chrsch commented Jan 9, 2019

This is a first step to provide a solution for #85.

If someone could point out how to bring on the BackendExtraMultilineSeparator option I can implement this as well.

@thomasjpfan
Copy link
Contributor

Thanks for the PR!

Editing how the template process strings, would make the code harder to follow. I would prefer BackendExtra be edited when GetServiceFromProvider here:

func GetServiceFromProvider(provider ServiceParameterProvider) *Service {
In GetServiceFromProvider, the backendExtraMultilineSeparator can be queried. If it is defined and has a non-zero length, it can be used to separate BackendExtra into multiple lines.

  • Test in types_test.go to make sure that BackendExtra is separated correctly.
  • This new feature would need to be documented in usage.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants