Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP 8.2.0 #1353

Merged
merged 2 commits into from
Dec 8, 2022
Merged

Add PHP 8.2.0 #1353

merged 2 commits into from
Dec 8, 2022

Conversation

TimWolla
Copy link
Contributor

@TimWolla TimWolla commented Dec 8, 2022

No description provided.

@jnoordsij
Copy link
Contributor

Note: I see #1354 was opened at almost exactly the same time, which also remove the no longer available RC-version, so might be preferable.

@TimWolla
Copy link
Contributor Author

TimWolla commented Dec 8, 2022

which also remove the no longer available RC-version

I've intentionally not touched the RC version, that one will automatically be removed by the bot when it runs update.sh.

@jnoordsij
Copy link
Contributor

Oh that works as well, true

@mdeboer
Copy link

mdeboer commented Dec 8, 2022

Hopefully this is merged soon 🚀

@mateuszsip mateuszsip mentioned this pull request Dec 8, 2022
@mateuszsip
Copy link

Didn't notice you were first, I just closed my PR 😄

@jnoordsij
Copy link
Contributor

I've intentionally not touched the RC version, that one will automatically be removed by the bot when it runs update.sh.

The bot has come! ;)

So now this has some merge conflicts. I rebased this in https://github.com/jnoordsij/docker-library-php/tree/php-8.2, feel free to use that or merge/rebase yourself.

@TimWolla
Copy link
Contributor Author

TimWolla commented Dec 8, 2022

So now this has some merge conflicts.

Gah, I hoped to avoid these by not touching the RC. I've just rebased locally and simply reran ./update.sh to perform all the magic. Thanks.

@TimWolla
Copy link
Contributor Author

TimWolla commented Dec 8, 2022

Wondering: Should we even provide buster / alpine3.16 variants for PHP 8.2? Running a brand new PHP on an old OS doesn't appear to be too useful to me?

@tianon
Copy link
Member

tianon commented Dec 8, 2022

Thank you!! ❤️

Wondering: Should we even provide buster / alpine3.16 variants for PHP 8.2? Running a brand new PHP on an old OS doesn't appear to be too useful to me?

Yeah, I feel the same way, but every time we drop N-1 in a new version, some user comes barreling in with a use case so I think it's simpler to stay mostly consistent across versions than to do extra work to exclude older distros on newer releases. 😅

(I think it also would've been good for us to be doing that on the pre-releases too, if we were going to 🙈)

@tianon tianon merged commit cc901e9 into docker-library:master Dec 8, 2022
@TimWolla TimWolla deleted the php-8.2 branch December 8, 2022 16:55
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Dec 8, 2022
@jnoordsij jnoordsij mentioned this pull request Nov 21, 2023
@jnoordsij jnoordsij mentioned this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants