Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gdbm-dev to slim and alpine images #153

Merged
merged 2 commits into from
Oct 25, 2016
Merged

Conversation

yosifkit
Copy link
Member

Happy green tests from docker-library/official-images#2284.

Non-slim, non-alpine images should still fail until a new buildpack-deps is created.

@tianon
Copy link
Member

tianon commented Oct 25, 2016

testing python:3.6-slim
    'utc' [1/8]...passed
    'cve-2014--shellshock' [2/8]...passed
    'no-hard-coded-passwords' [3/8]...passed
    'override-cmd' [4/8]...passed
    'python-hy' [5/8]...skipping Hy test -- no workie on Python 3.6+
passed
    'python-imports' [6/8]...Traceback (most recent call last):
  File "./container.py", line 15, in <module>
    import dbm.gnu
  File "/usr/local/lib/python3.6/dbm/gnu.py", line 3, in <module>
    from _gdbm import *
ImportError: libgdbm.so.3: cannot open shared object file: No such file or directory
failed
    'python-pip-requests-ssl' [7/8]...passed
    'python-sqlite3' [8/8]...passed

@yosifkit
Copy link
Member Author

yosifkit commented Oct 25, 2016

Hmmm, that is similar to how tk currently works; we add it for building but require the user to install the apt package of they want to use it. Do we want to keep it that way?

It is "better" than the old error:

Python 3.6.0b2 (default, Oct 15 2016, 06:24:15) 
[GCC 4.9.2] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import dbm.gnu
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python3.6/dbm/gnu.py", line 3, in <module>
    from _gdbm import *
ModuleNotFoundError: No module named '_gdbm'

Edit: I am more for keeping the lib around, since it was reported earlier when we had no dbm.

@yosifkit
Copy link
Member Author

💚 Green in all the right places!

@tianon
Copy link
Member

tianon commented Oct 25, 2016

Yeah, keeping it around here seems more sane IMO than TK -- it's likely more common and should have a smaller footprint overall anyhow. 👍

LGTM

@tianon tianon merged commit b031a3a into docker-library:master Oct 25, 2016
@tianon tianon deleted the gdbm branch October 25, 2016 23:58
tianon added a commit to infosiftr/stackbrew that referenced this pull request Oct 27, 2016
- `buildpack-deps`: add `libgdbm-dev` (docker-library/buildpack-deps#49)
- `celery`: 4.0.0rc6
- `docker`: 1.12.3
- `java`: switch from `httpredir.debian.org` to `deb.debian.org`
- `kibana`: remove obsolete comments
- `mysql`: add `-hlocalhost` during init to avoid `MYSQL_HOST` interference (docker-library/mysql#222)
- `openjdk`: switch from `httpredir.debian.org` to `deb.debian.org`
- `percona`: 5.7.15-9-1.jessie
- `php`: 7.1.0RC5
- `piwik`: 2.17.0
- `postgres`: 9.1.24-1.pgdg80+1, 9.2.19-1.pgdg80+1, 9.3.15-1.pgdg80+1, 9.4.10-1.pgdg80+1, 9.5.5-1.pgdg80+1, 9.6.1-1.pgdg80+1
- `python`: add `gdbm-dev` to `slim` and `alpine` (docker-library/python#153)
- `redis`: 3.2.5
- `rocket.chat`: 0.44.0
- `ruby`: bundler 1.13.6
- `tomcat`: switch from `httpredir.debian.org` to `deb.debian.org`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants