feat: add a prefix path to TUF client #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonnystoten
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #159 +/- ##
==========================================
+ Coverage 68.17% 68.24% +0.06%
==========================================
Files 41 41
Lines 2423 2428 +5
==========================================
+ Hits 1652 1657 +5
Misses 495 495
Partials 276 276
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kipz
reviewed
Sep 10, 2024
whalelines
reviewed
Sep 10, 2024
whalelines
reviewed
Sep 10, 2024
| } | ||
| } | ||
|
|
||
| var validPathPrefix = regexp.MustCompile("^[a-z0-9_-]*$") |
There was a problem hiding this comment.
Suggested change
| var validPathPrefix = regexp.MustCompile("^[a-z0-9_-]*$") | |
| var validPathPrefix = regexp.MustCompile("^[a-z0-9_-]+$") |
It should have at least one character, no?
There was a problem hiding this comment.
No, the default is empty to read from the root.
mrjoelkamp
reviewed
Sep 10, 2024
|
Ha, the
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to allow us to store new policy files in the production TUF repository under a
testingdelegation, and for clients to opt-in to using this testing delegation when retrieving policy from TUF.If the prefix path is set, it is prepended to every target path on download with
path.Join. For example, if the prefix path istestingand we download the targeta/b, the TUF client with actually downloadtesting/a/b.Also get the latest testdata from tuf-dev.