Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add verifier version to vsa #201

Merged
merged 3 commits into from
Oct 17, 2024
Merged

Conversation

mrjoelkamp
Copy link
Contributor

@mrjoelkamp mrjoelkamp commented Oct 16, 2024

summary

  • creates a version fetcher interface
  • adds verifier.version to VSA output
  • adds version_test.go for version checker tests

@mrjoelkamp mrjoelkamp requested a review from a team as a code owner October 16, 2024 17:02
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 4 lines in your changes missing coverage. Please review.

Project coverage is 70.75%. Comparing base (eda0b23) to head (7ff20a9).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
attestation/vsa.go 77.77% 1 Missing and 1 partial ⚠️
verify.go 81.81% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #201      +/-   ##
==========================================
+ Coverage   70.08%   70.75%   +0.66%     
==========================================
  Files          44       44              
  Lines        2577     2595      +18     
==========================================
+ Hits         1806     1836      +30     
+ Misses        474      457      -17     
- Partials      297      302       +5     
Flag Coverage Δ
unittests 70.75% <85.71%> (+0.66%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jonnystoten jonnystoten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tuf/version.go Outdated Show resolved Hide resolved
@mrjoelkamp mrjoelkamp merged commit 17b0978 into main Oct 17, 2024
9 checks passed
@mrjoelkamp mrjoelkamp deleted the feat--add-verifier-version-to-vsa branch October 17, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants