Support Windows image builds #18
Comments
|
Hi @sixeyed, thanks for your feedback. This is interesting and I can see it being useful. Currently the action runs using a Linux container hence it wouldn't work with the Windows hosts so this will need some investigating on the best way to support this. I will discuss this with our PM and see if we can get it prioritized |
|
FYI this is working with Windows https://github.com/mr-smithers-excellent/docker-build-push but hitting some issues on second push. We have Linux images and Windows based images (for On prem customers). |
|
I worked several days to build a Windows image locally with all our stack (C++/Qt based application) only to find out I could not build and use the final image with an action. Sad 😄 |
|
I would also be interested in this action working on Windows. |
|
I am also interested in this action working on Windows. |
|
Are there any plans to have this action work on windows too? |
|
Hey folks, just to add traction here, we would also benefit from having this action working on Windows. Is there any way folks outside of Docker (like myself) can contribute to do this? |
|
@ian-flores |
Windows containers require a special treatment due to buildx not being compatible, yet. Relates to docker/buildx#176 Relates to docker/build-push-action#18
Windows containers require a special treatment due to buildx not being compatible, yet. Relates to docker/buildx#176 Relates to docker/build-push-action#18
11040: ci(smoke-test): multi-arch container smoke test r=megglos a=megglos ## Description Docker builds and smoke tests are only run on Linux machines as building docker containers on macOS and windows runners introduces complexity to the CI setup that we consider not worth the effort: - macOS runners require the setup of [colima as a docker runtime](actions/runner-images#6216) which adds another 1.5-2m to the runtime - on macOS testcontainers failed to detect the docker environment unless [additional environment variables](https://www.testcontainers.org/features/configuration/#customizing-docker-host-detection) have been set - some docker related actions are not supported on windows runners like [`docker/build-push-action`](docker/build-push-action#18 (comment)) - the docker setup on Githubs windows runners seems to be bound to the `windows/amd64` platform, see e.g. this [log](https://github.com/camunda/zeebe/actions/runs/3500015748/jobs/5862231609) Usage of native arm64 runners is listed as a separate sub-task on #10986. ## Related issues closes #11020 Co-authored-by: Meggle (Sebastian Bathke) <[email protected]> Co-authored-by: Sebastian Bathke (Meggle) <[email protected]>
|
Will this be implemented in the near future? |
|
As of last week, buildkit |
|
Also keen on this feature! |
|
Yes please!! Would help our adoption of Github Actions no end |
The GitHub runner
windows-2019has Docker installed, so you can build and push images with a workflow like this:Would be great if this action supported Windows image builds on Windows runners.
The text was updated successfully, but these errors were encountered: