login: print a big warning when using --password

Task command lines are world readable via /proc/pid/cmdline, so this isn't safe. Signed-off-by: Tycho Andersen <[email protected]>
docker · Jul 3, 2017 · c269ad2 · c269ad2
1 parent 92a2a1d
commit c269ad2
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/cli/command/registry/login.go b/cli/command/registry/login.go
@@ -47,6 +47,10 @@ func runLogin(dockerCli command.Cli, opts loginOptions) error {
 	ctx := context.Background()
 	clnt := dockerCli.Client()
 
+	if opts.password != "" {
+		fmt.Fprintln(dockerCli.Err(), "WARNING! Using --password via the CLI is insecure.")
+	}
+
 	var (
 		serverAddress string
 		authServer    = command.ElectAuthServer(ctx, dockerCli)