Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.03 backport] Complete capabilites with and without "CAP_" prefix. #2724

Merged
merged 1 commit into from
Sep 17, 2020
Merged

[19.03 backport] Complete capabilites with and without "CAP_" prefix. #2724

merged 1 commit into from
Sep 17, 2020

Conversation

thaJeztah
Copy link
Member

backport of #2706

@albers @thaJeztah
Complete capabilites with and without "CAP_" prefix.
75411a2 
Signed-off-by: Harald Albers <[email protected]>
(cherry picked from commit 015cb98)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah added this to the 19.03.13 milestone Sep 16, 2020
@thaJeztah thaJeztah requested a review from albers as a code owner September 16, 2020 13:55
@thaJeztah thaJeztah mentioned this pull request Sep 16, 2020
Merged
@thaJeztah
Copy link
Member Author

@albers @silvin-lubecki ptal

@codecov-commenter
Copy link

Codecov Report

Merging #2724 into 19.03 will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            19.03    #2724   +/-   ##
=======================================
  Coverage   56.98%   56.98%           
=======================================
  Files         312      312           
  Lines       21908    21908           
=======================================
  Hits        12484    12484           
  Misses       8504     8504           
  Partials      920      920

silvin-lubecki
silvin-lubecki approved these changes Sep 16, 2020
View reviewed changes
Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah marked this pull request as draft September 17, 2020 12:37
@thaJeztah
Copy link
Member Author

temporarily moving to draft, as we'll be starting 19.03.13 builds soon

@thaJeztah thaJeztah modified the milestones: 19.03.13, 19.03.14 Sep 17, 2020
albers
albers approved these changes Sep 17, 2020
View reviewed changes
Copy link
Collaborator

@albers albers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@thaJeztah thaJeztah marked this pull request as ready for review September 17, 2020 23:31
@thaJeztah thaJeztah merged commit 9aa3848 into docker:19.03 Sep 17, 2020
@thaJeztah thaJeztah deleted the 19.03_backport_cap_completion branch September 17, 2020 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albers albers albers approved these changes

@silvin-lubecki silvin-lubecki silvin-lubecki approved these changes

Assignees
No one assigned
Labels
area/completion status/2-code-review
Projects
None yet
Milestone
19.03.14
Development

Successfully merging this pull request may close these issues.
4 participants
@thaJeztah @codecov-commenter @albers @silvin-lubecki