-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update buildkit take2 #3237
Update buildkit take2 #3237
Conversation
Arf.. looks like this is causing issues; google/gnostic@896953e.
|
And more errors currently;
Those should be because the version that was specified is too old (needs v1.4 or above; golang/protobuf@ae97035) |
e572e11
to
844714b
Compare
oh! this one is weird
also
Last one;
and
Getting closer;
https://github.com/moby/buildkit/blob/v0.9.0/vendor/modules.txt#L280
And closer;
https://github.com/moby/buildkit/blob/v0.9.0/vendor/modules.txt#L486
|
0fe49ec
to
9c73b72
Compare
vendor.conf
Outdated
github.com/xeipuuv/gojsonpointer 02993c407bfbf5f6dae44c4f4b1cf6a39b5fc5bb | ||
github.com/xeipuuv/gojsonreference bd5ef7bd5415a7ac448318e64f11a24cd21e594b | ||
github.com/xeipuuv/gojsonschema 82fcdeb203eb6ab2a67d0a623d9c19e5e5a64927 # v1.2.0 | ||
go.opentelemetry.io/contrib 91e5180ae03828601f705ac8e7fc3bd9e34dae6a # v0.21.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to check if we need the fork for this; https://github.com/moby/buildkit/blob/v0.9.0/go.mod#L79-L83
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes indeed I didn't take these ones into account. Hopefully should be fixed upstream soon:
- otelhttp: get tracer from current context if not set in constructor open-telemetry/opentelemetry-go-contrib#873
- otelhttptrace: get tracer from request if available open-telemetry/opentelemetry-go-contrib#874
- otelhttp: add WithClientTrace to connect with otelhttptrace open-telemetry/opentelemetry-go-contrib#875
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a commit to use that fork
Codecov Report
@@ Coverage Diff @@
## master #3237 +/- ##
=======================================
Coverage 57.99% 57.99%
=======================================
Files 302 302
Lines 21764 21764
=======================================
Hits 12621 12621
Misses 8219 8219
Partials 924 924 |
29e5d20
to
dd2fd75
Compare
dd2fd75
to
9621977
Compare
Signed-off-by: CrazyMax <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
9621977
to
e2487f9
Compare
…8dfe full diff: moby/buildkit@fc3c182...9b010e7 Signed-off-by: Sebastiaan van Stijn <[email protected]>
e2487f9
to
ae797e8
Compare
quick try to make #3232 work