Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct device syntax to --gpus #3414

Merged
merged 1 commit into from
Jan 31, 2022
Merged

Conversation

patel-zeel
Copy link
Contributor

- What I did
Changed device=0,2 to '"device=0,2"'.
- How I did it
Editing run.md.
- How to verify it
By executing both examples and checking which one works.
- Description for the changelog

Improvement in Docs.

- A picture of a cute animal (not mandatory but encouraged)
image

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

These comma-separated values are tricky indeed, as the --gpus flag options are CSV formatted 😥

@codecov-commenter
Copy link

Codecov Report

Merging #3414 (2d6ebd1) into master (5bb88dc) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3414   +/-   ##
=======================================
  Coverage   56.36%   56.36%           
=======================================
  Files         304      304           
  Lines       26816    26816           
=======================================
  Hits        15114    15114           
  Misses      10782    10782           
  Partials      920      920           

@thaJeztah thaJeztah merged commit 36f6017 into docker:master Jan 31, 2022
@patel-zeel
Copy link
Contributor Author

patel-zeel commented Jan 31, 2022

LGTM, thanks!

Thank you for approving the PR @thaJeztah.

These comma-separated values are tricky indeed, as the --gpus flag options are CSV formatted 😥

Yes, indeed :)

This may help the following issues:

@patel-zeel patel-zeel changed the title Correct device syntax to --gpus Correct device syntax to --gpus Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants