complete the "-g" / "--graph" daemon option deprecation #3739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3739 +/- ##
=======================================
Coverage 59.15% 59.15%
=======================================
Files 289 289
Lines 24674 24674
=======================================
Hits 14597 14597
Misses 9206 9206
Partials 871 871 |
These options were soft-deprecated in Docker 17.05, and at the time considered to not be removed. However, with the move towards containerd snapshotters, having these options around adds additional complexity to handle fallbacks for deprecated (and hidden) flags, so completing the deprecation. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
hard_deprecate_graph
branch
from
34a8a3c to
304c100
Compare
cpuguy83
approved these changes
Aug 18, 2022
ahmedsajid
added a commit
to ahmedsajid/ansible-role-docker
that referenced
this pull request
Feb 2, 2023
replaced with `data-root` in latest release https://github.com/moby/moby/releases/tag/v23.0.0 ``` Remove the -g and --graph daemon options in favor of --data-root. docker/cli#3739 These options have been hidden and deprecated since 17.05. Deprecation notice ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These options were soft-deprecated in Docker 17.05 (moby/moby#28696), and at the time considered to not be removed. However, with the move towards containerd snapshotters, having these options around adds additional complexity to handle fallbacks for deprecated (and hidden) flags, so completing the deprecation.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)