Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimise docker stats to not require clearing the whole screen #5625

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

Giedriusj1
Copy link
Contributor

Instead of clearing the whole screen and then writing the new stats, we now write the new stats on top of the old text, and then clear the remaining text.

This is a more efficient way to update the stats, as it avoids the flickering that happens when the screen is cleared and rewritten.

This improves upon #5586

Instead of clearing the whole screen and then writing the new stats,
we now write the new stats on top of the old text, and then clear
the remaining text.

This is a more efficient way to update the stats, as it avoids the
flickering that happens when the screen is cleared and rewritten.

Signed-off-by: Giedrius Jonikas <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 59.49%. Comparing base (9861ce9) to head (cb2f95c).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5625      +/-   ##
==========================================
- Coverage   59.50%   59.49%   -0.02%     
==========================================
  Files         346      346              
  Lines       29365    29371       +6     
==========================================
  Hits        17474    17474              
- Misses      10916    10922       +6     
  Partials      975      975              
---- 🚨 Try these New Features:

Copy link
Member

@laurazard laurazard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I'd like to add some tests/otherwise refactor this area, but that's orthogonal to this PR and this looks safe

@thaJeztah thaJeztah added this to the 28.0.0 milestone Nov 19, 2024
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit 81401f3 into docker:master Nov 19, 2024
98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants