-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli-plugins/manager: IsNotFound: don't depend on causer interface #5794
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5794 +/- ##
==========================================
- Coverage 59.44% 59.17% -0.27%
==========================================
Files 347 353 +6
Lines 29394 29472 +78
==========================================
- Hits 17472 17440 -32
- Misses 10950 11059 +109
- Partials 972 973 +1 |
err = e.Cause() | ||
var e *pluginError | ||
if errors.As(err, &e) { | ||
err = e.Unwrap() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you be able to add more context to the commit on why this needs to change?
The error could also be wrapped multiple times before it's a notFound
type. Are we sure we never wrap the error more than once?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can also get this one merged soon if you'd like. I don't have the full context yet though (see previous comment), but the change seems alright.
Oh! Sorry forgot about this one; I need to double-check if this could cause a change in behavior; considering that |
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)