Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Notary vendor to 0.6.0 release #914

Merged
merged 1 commit into from
Mar 7, 2018

Conversation

justincormack
Copy link
Member

We were on a slightly earlier random commit.

We should try to stay on releases where possible...

Signed-off-by: Justin Cormack [email protected]

Copy link
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

@codecov-io
Copy link

codecov-io commented Mar 1, 2018

Codecov Report

Merging #914 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #914   +/-   ##
=======================================
  Coverage   53.53%   53.53%           
=======================================
  Files         262      262           
  Lines       16603    16603           
=======================================
  Hits         8888     8888           
  Misses       7124     7124           
  Partials      591      591

@thaJeztah
Copy link
Member

Full diff: notaryproject/notary@05985dc...v0.6.0

Changes included:

@justincormack can you check if we need to bump Notary's dependencies to match?

Already ahead:

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like to have a check if we need the updated dependencies

@thaJeztah
Copy link
Member

Also see e2e tests pin to notary 0.4.2 3 (likely not relevant);

version: '2.1'

We were on a slightly earlier random commit.

We should try to stay on releases where possible...

Signed-off-by: Justin Cormack <[email protected]>
@justincormack
Copy link
Member Author

Added the pkcs11 dep update. go-connections only affects servers so not really important here, we should probably update when we update docker.

@justincormack
Copy link
Member Author

The library images havent been updated yet...

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit f351f00 into docker:master Mar 7, 2018
@GordonTheTurtle GordonTheTurtle added this to the 18.04.0 milestone Mar 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants