-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Notary vendor to 0.6.0 release #914
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🐯
Codecov Report
@@ Coverage Diff @@
## master #914 +/- ##
=======================================
Coverage 53.53% 53.53%
=======================================
Files 262 262
Lines 16603 16603
=======================================
Hits 8888 8888
Misses 7124 7124
Partials 591 591 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
like to have a check if we need the updated dependencies
Also see e2e tests pin to notary 0.4.2 3 (likely not relevant); Line 1 in b70f929
|
We were on a slightly earlier random commit. We should try to stay on releases where possible... Signed-off-by: Justin Cormack <[email protected]>
Added the pkcs11 dep update. go-connections only affects servers so not really important here, we should probably update when we update docker. |
The library images havent been updated yet... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We were on a slightly earlier random commit.
We should try to stay on releases where possible...
Signed-off-by: Justin Cormack [email protected]