Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix support for --remove-orphans on docker compose run #12288

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Nov 12, 2024

What I did
Fix: remove-orphans flag was assigned to createOptions we don't use to run convergence

Related issue
fixes #12015

(not mandatory) A picture of a cute animal, if possible in relation to what you did

@ndeloof ndeloof requested review from a team and glours and removed request for a team November 12, 2024 11:35
Signed-off-by: Nicolas De Loof <[email protected]>
Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glours glours merged commit bf521fe into docker:main Nov 12, 2024
28 checks passed
@ndeloof ndeloof deleted the run-remove-orphans branch November 12, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Weird behavior between orphaned containers and --remove-orphans flag
2 participants