Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove need for SUFFIX in gen-deb-ver #200

Merged
merged 1 commit into from
Sep 12, 2018

Conversation

seemethere
Copy link
Contributor

@seemethere seemethere commented Sep 12, 2018

Should generate correct bits whether or not the suffix is present.

Working example:

❯ for version in 18.09.1-ce 18.09.1 18.09.1-ce-rc1 18.09.1-rc1; do echo "$ ./gen-deb-ver . $version"; ./gen-deb-ver . "$version"; echo; done
$ ./gen-deb-ver . 18.09.1-ce
18.09.1~ce~3 18.09.1-ce

$ ./gen-deb-ver . 18.09.1
18.09.1~3 18.09.1

$ ./gen-deb-ver . 18.09.1-ce-rc1
18.09.1~ce~2.1.rc1 18.09.1-ce-rc1

$ ./gen-deb-ver . 18.09.1-rc1
18.09.1~2.1.rc1 18.09.1-rc1

Signed-off-by: Eli Uriegas [email protected]

Should generate correct bits whether or not the suffix is present.

Working example:

❯ ./gen-deb-ver . 18.09.0-beta1
18.09.0~1.1.beta1 18.09.0-beta1

❯ ./gen-deb-ver . 18.09.0-ce-beta1
18.09.0~ce~1.1.beta1 18.09.0-ce-beta1

Signed-off-by: Eli Uriegas <[email protected]>
Copy link

@jose-bigio jose-bigio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seemethere seemethere merged commit 41db4de into docker:master Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants