Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for floats in "since" kwarg on logs(). #1515

Closed
mccalluc opened this issue Mar 17, 2017 · 2 comments
Closed

Add support for floats in "since" kwarg on logs(). #1515

mccalluc opened this issue Mar 17, 2017 · 2 comments
Labels
Milestone

Comments

@mccalluc
Copy link
Contributor

The documentation is clear:

since (datetime or int) – Show logs since a given datetime or integer epoch

but it's easy for someone to overlook that and pass in something based on a float from time.time() and since will just be ignored. Would a PR that supported any number or a datetime be welcome?

django-docker-engine==0.0.1
docker==2.1.0
docker-pycreds==0.2.1
Python 2.7.13 :: Continuum Analytics, Inc.
Client:
 Version:      17.03.0-ce
 API version:  1.26
 Go version:   go1.7.5
 Git commit:   60ccb22
 Built:        Thu Feb 23 10:40:59 2017
 OS/Arch:      darwin/amd64

Server:
 Version:      17.03.0-ce
 API version:  1.26 (minimum version 1.12)
 Go version:   go1.7.5
 Git commit:   3a232c8
 Built:        Tue Feb 28 07:52:04 2017
 OS/Arch:      linux/amd64
 Experimental: true
@shin-
Copy link
Contributor

shin- commented Apr 27, 2017

Yes - I agree it shouldn't be ignored. Raising an error if a float is provided would be the appropriate course of action.

@fopinappb
Copy link

I know this has been closed long time ago, but maybe it should be revisited as apparently the API does support floats (for added - and useful - precision).

moby/moby#41784 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants