-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for floats to docker logs params since / until sinc… #3031
Conversation
3fa85c7
to
7c1e4cc
Compare
…e the docker engine supports it Signed-off-by: Archi Moebius <[email protected]>
7c1e4cc
to
c92c03d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Looks good -- just a couple tiny suggestions to update the error messages for unsupported types.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah another thing - "in nanoseconds" is misleading
Co-authored-by: Milas Bowman <[email protected]> Signed-off-by: Rhiza <[email protected]>
Co-authored-by: Milas Bowman <[email protected]> Signed-off-by: Rhiza <[email protected]>
Co-authored-by: Milas Bowman <[email protected]> Signed-off-by: Rhiza <[email protected]>
Co-authored-by: Milas Bowman <[email protected]> Signed-off-by: Rhiza <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [docker](https://togithub.com/docker/docker-py) ([changelog](https://docker-py.readthedocs.io/en/stable/change-log.html)) | patch | `6.0.0` -> `6.0.1` | --- ### Release Notes <details> <summary>docker/docker-py</summary> ### [`v6.0.1`](https://togithub.com/docker/docker-py/releases/tag/6.0.1) [Compare Source](https://togithub.com/docker/docker-py/compare/6.0.0...6.0.1) ##### 🐛 Bugfixes - Fix for `The pipe has been ended` errors on Windows ([#​3056](https://togithub.com/docker/docker-py/issues/3056)) - Support floats for timestamps in Docker logs (`since` / `until`) ([#​3031](https://togithub.com/docker/docker-py/issues/3031)) ##### What's Changed - docs: install package in ReadTheDocs build by [@​milas](https://togithub.com/milas) in [https://github.com/docker/docker-py/pull/3032](https://togithub.com/docker/docker-py/pull/3032) - Use latest stable syntax for Dockerfiles by [@​thaJeztah](https://togithub.com/thaJeztah) in [https://github.com/docker/docker-py/pull/3035](https://togithub.com/docker/docker-py/pull/3035) - feat: add support for floats to docker logs params since / until sinc… by [@​ArchiMoebius](https://togithub.com/ArchiMoebius) in [https://github.com/docker/docker-py/pull/3031](https://togithub.com/docker/docker-py/pull/3031) - Change prune test to use anonymous volumes by [@​cpuguy83](https://togithub.com/cpuguy83) in [https://github.com/docker/docker-py/pull/3051](https://togithub.com/docker/docker-py/pull/3051) - socket: handle npipe close by [@​nicks](https://togithub.com/nicks) in [https://github.com/docker/docker-py/pull/3056](https://togithub.com/docker/docker-py/pull/3056) ##### New Contributors - [@​ArchiMoebius](https://togithub.com/ArchiMoebius) made their first contribution in [https://github.com/docker/docker-py/pull/3031](https://togithub.com/docker/docker-py/pull/3031) - [@​nicks](https://togithub.com/nicks) made their first contribution in [https://github.com/docker/docker-py/pull/3056](https://togithub.com/docker/docker-py/pull/3056) **Full Changelog**: docker/docker-py@6.0.0...6.0.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMi4xIiwidXBkYXRlZEluVmVyIjoiMzQuMTIuMSJ9--> Co-authored-by: lumiere-bot <98047013+lumiere-bot[bot]@users.noreply.github.com>
feature to add support for floats to docker container logs method params
since / until
due to the fact that docker engine supports itRelated:
#1515
#2825