This repository has been archived by the owner on Nov 23, 2019. It is now read-only.
Adding link (local alias) config in endpointsettings #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Madhu Venugopal <[email protected]>
mavenugo
changed the title
|
@calavera I decided to split the PR between local and global alias in engine-api to reflect the reality as discussed in the maintainers meeting. |
|
LGTM |
|
@calavera am waiting on moby/moby#19198 to be merged before pushing the docker side changes for the alias functionality as discussed. I hope we can get this in soon so that we can avoid temporary vendor-in changes. |
|
LGTM |
calavera
added a commit
that referenced
this pull request
Jan 9, 2016
Adding link (local alias) config in endpointsettings
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the alias fields in engine-api for the upcoming local alias feature (via link)
Signed-off-by: Madhu Venugopal [email protected]