This repository has been archived by the owner on Sep 14, 2023. It is now read-only.
Allow generic decoding of usage into a type #31
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writing a generic decode function over any types, one is tempted to write
something along the lines of:
Currently there are two problems with this approach.
docopt::Decoder
structure is private, so it cannot be referenced in afunction signature.
Decoder
prevents usage of the local variablemap
. Thedecode
function requires&'a self
, which requires callers ofthis function to provide a lifetime variable
'a
which is the lifetime ofthe stack frame of
foo
itself. Sadly this cannot currently be done (higherranked trait lifetimes maybe?).
To work around these two problems, I've made the
Decoder
structure public andchanged the
decode
method onValueMap
to consume the map, removing thelifetime parameter on
Decoder
.There may be some more generic wizardry to get around this problem, but this at
least seems to work for now! Does this seem ok to you?