-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finalize ORM 3 Support #2814
Merged
Merged
Finalize ORM 3 Support #2814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2814 +/- ##
==========================================
+ Coverage 78.75% 78.79% +0.04%
==========================================
Files 163 167 +4
Lines 8593 8629 +36
==========================================
+ Hits 6767 6799 +32
- Misses 1826 1830 +4 ☔ View full report in Codecov by Sentry. |
…-version compatibility
…ace when the annotations library is installed with ORM 3
…use a more specific return than mixed
franmomu
approved these changes
Jun 10, 2024
Thank you @mbabker for all the work you're doing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be the last bit that's needed to finish out #2708.
Needs Run tests withoutHandled in the testing bootstrap insteaddoctrine/annotations
installed #2781 to merge first to be able to build on the CI architecture (it's blowing up pretty badly right now because of the presence ofdoctrine/annotations
and the auto-detection code in ourGedmo\Mapping\MappedEventSubscriber
class)I haven't even looked at the PHPStan report yet, that can be dealt with once we have consistent green PHPUnit buildsBaseline refreshed