make Base LifecycleEventArgs usable in orm and odm #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, thank you for positing this Pull Request. I have automatically opened an issue on our Jira Bug Tracker for you with the details of this Pull-Request. See the Link: |
|
|
||
| /** | ||
| * @var object | ||
| */ | ||
| private $entity; | ||
| protected $object; |
There was a problem hiding this comment.
why changing the visibility ? You have getter for them, and child classes are not meant to replace them either
beberlei
added a commit
that referenced
this pull request
Dec 5, 2012
make Base LifecycleEventArgs usable in orm and odm
This was referenced Dec 5, 2012
|
@beberlei: Will this be in the 2.3.1 release? And if so, any ETA on when that might be? |
|
@jmikola This is only in master AFAIK, so it is probably for 2.4 |
|
Ah, I didn't realize there was a separate 2.3 branch already. Makes sense, thanks! |
This was referenced Dec 6, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull requests are to come for both orm and odm to make use of this.
The main goal is to make more abstract listeners, compatible with both orm and odm.