Added explicit configuration methods to TransactionBuilder

doctrine · Aug 23, 2014 · a6985cb · a6985cb
1 parent 6fa6002
commit a6985cb
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 9 deletions.
diff --git a/lib/Doctrine/DBAL/Connection.php b/lib/Doctrine/DBAL/Connection.php
@@ -48,11 +48,6 @@
  */
 class Connection implements DriverConnection
 {
-    /**
-     * Constant for transaction isolation level configuration variable.
-     */
-    const ISOLATION_LEVEL = 'dbal.isolation-level';
-
     /**
      * Constant for transaction isolation level READ UNCOMMITTED.
      */

diff --git a/lib/Doctrine/DBAL/TransactionBuilder.php b/lib/Doctrine/DBAL/TransactionBuilder.php
@@ -7,6 +7,8 @@
  */
 class TransactionBuilder
 {
+    const ISOLATION_LEVEL = 'dbal.isolation-level';
+
     /**
      * The transaction manager.
      *
@@ -32,20 +34,30 @@ public function __construct(TransactionManager $manager)
     }
 
     /**
-     * Sets the isolation level for this transaction.
+     * Sets a configuration variable.
      *
      * @param string $configurationName  The configuration variable name.
      * @param string $configurationValue The configuration value.
      *
      * @return \Doctrine\DBAL\TransactionBuilder The current instance for chaining.
      */
-    public function with($configurationName, $configurationValue)
+    protected function with($configurationName, $configurationValue)
     {
         $this->configuration[$configurationName] = $configurationValue;
 
         return $this;
     }
 
+    /**
+     * @param integer $isolationLevel
+     *
+     * @return \Doctrine\DBAL\TransactionBuilder
+     */
+    public function withIsolationLevel($isolationLevel)
+    {
+        return $this->with(self::ISOLATION_LEVEL, $isolationLevel);
+    }
+
     /**
      * Begins the transaction and returns the associated Transaction object.
      *

diff --git a/lib/Doctrine/DBAL/TransactionManager.php b/lib/Doctrine/DBAL/TransactionManager.php
@@ -51,8 +51,8 @@ public function beginTransaction(array $configuration = array())
     {
         $this->connection->connect();
 
-        if (isset($configuration[Connection::ISOLATION_LEVEL])) {
-            $this->connection->setTransactionIsolation($configuration[Connection::ISOLATION_LEVEL]);
+        if (isset($configuration[TransactionBuilder::ISOLATION_LEVEL])) {
+            $this->connection->setTransactionIsolation($configuration[TransactionBuilder::ISOLATION_LEVEL]);
         }
 
         $transaction = new Transaction($this, $configuration);