Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing type hints in $query, $params, $types sets #3034

Closed
wants to merge 44 commits into from
Closed

Missing type hints in $query, $params, $types sets #3034

wants to merge 44 commits into from

Conversation

simPod
Copy link
Contributor

@simPod simPod commented Feb 28, 2018

No description provided.

Ocramius
Ocramius approved these changes Mar 1, 2018
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good from here, although unsure if this will be a BC break (too little ☕ and toi early in the morning)

@Majkl578
Copy link
Contributor

Majkl578 commented Mar 2, 2018

Wouldn't pursue similar changes until develop lands in master, too early in the DBAL 3.0 cycle.
Otherwise needs rebase and fixing CS.

@morozov morozov force-pushed the develop branch 3 times, most recently from 7b7cffe to c5e8a7c Compare March 19, 2018 19:11
@morozov morozov force-pushed the develop branch 3 times, most recently from fd275f8 to c78e0e5 Compare April 9, 2018 15:30
guilhermeblanco and others added 19 commits April 20, 2018 20:58
@guilhermeblanco @morozov
Decouple unique index from unique constraint
ac3c76a
@guilhermeblanco @morozov
Added flag support to unique constraint
bdf7f70
@guilhermeblanco @morozov
Fixed tests
fed2569
@guilhermeblanco @morozov
Removed identifier generator type from schema table definition
76c0989
@guilhermeblanco @morozov
Fixing rebase with master
7816fb3
@guilhermeblanco @morozov
Fixed undefined result of rebase
fc45f88
@guilhermeblanco @morozov
Moved getSequencePrefix() from ClassMetadata (ORM) to AbstractPlatfor…
e00ed87 
…m (DBAL)
@Majkl578 @morozov
Remove copyright headers
9e985ef
@Majkl578 @morozov
Require PHP 7.2, drop <7.2 in Composer & on CI
4505b3a
@Majkl578 @morozov
Bump version to 3.0.x-dev
94ba564
@morozov
[BC] Removed support for PDO::PARAM_INPUT_OUTPUT in Statement::bindPa…
fb6ed7c 
…ram()
@morozov
[BC] Replaced extension of \PDOStatement with a composition to avoid …
9299942 
…having to replicate the \PDOStatement interface in ResultStatement
@morozov
[BC] Replaced PDO constants with values
291cd1f
@morozov
Updated UPGRADE.md for 3.x
fa9a448
@morozov
Updated build matrix for Travis-CI according to the changes in compos…
17cd070 
…er.json

Fixes doctrine#2994.
@Majkl578 @morozov
Drop Doctrine\DBAL\Version in favor of Ocramius\PackageVersions
e133242
@BenMorel @morozov
Drop Drizzle support
c80e70a
@BenMorel @morozov
Add note to UPGRADE.md
6a2a9af
@BenMorel @morozov
Introduce a null SQL logger
476742f
morozov added 5 commits April 20, 2018 20:58
@morozov
Fixed build failure on SQL Server (sqlsrv)
525baa4 
The regression was introduced by 2b8c40d.

Fixes doctrine#3060.
@morozov
Fixed build failure on SQL Server (pdo_sqlsrv)
fe91b22 
Use a wrapped PDO Statement instead of a custom class for `pdo_sqlsrv` since `PDOSqlsrv\Statement` doesn't extend `PDOStatement` anymore.
@morozov
[DBAL-3079] Reworked the usage of PDO inPDOConnection from inheritanc…
a62acbd 
…e to composition
@morozov
[DBAL-3079] Added type hints to query-related method parameters and r…
4fd0e86 
…eturn values
@morozov
[DBAL-3079] Updated upgrade documentation
1c91686
@simPod
Copy link
Contributor Author

simPod commented Apr 26, 2018

Done

Majkl578
Majkl578 suggested changes Apr 26, 2018
View reviewed changes
Copy link
Contributor

@Majkl578 Majkl578 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think we shouldn't do this until develop is merged into master. (Same as fixing CS globally.)

@simPod
Copy link
Contributor Author

simPod commented May 5, 2018

ping me if needed ;)

@morozov morozov force-pushed the develop branch 2 times, most recently from 72cddfb to d8f1786 Compare June 6, 2018 21:46
@morozov morozov force-pushed the develop branch 3 times, most recently from 67bd64c to 7e5fb71 Compare July 2, 2018 00:52
@morozov morozov force-pushed the develop branch 2 times, most recently from c4478a0 to e5a586e Compare October 7, 2018 22:01
@morozov morozov force-pushed the develop branch 2 times, most recently from 0a11c71 to fa42c10 Compare November 14, 2018 19:23
@ostrolucky
Copy link
Member

superseded with #3348

@ostrolucky ostrolucky closed this Nov 17, 2018
@ostrolucky ostrolucky self-assigned this Nov 17, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Majkl578 Majkl578 Majkl578 requested changes

@Ocramius Ocramius Ocramius approved these changes

Assignees

@ostrolucky ostrolucky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@simPod @Majkl578 @ostrolucky @Ocramius @guilhermeblanco @morozov @BenMorel