Code

Enable PHPStan strict rules#3932

Code

Merged

morozov merged 19 commits intodoctrine:3.0.xdoctrine/dbal:3.0.xfrom morozov:phpstan-strictermorozov/dbal:phpstan-stricterCopy head branch name to clipboardApr 11, 2020

+1,132-929

Commits

Commits on Apr 8, 2020

• Enabled PHPStan strict rules

  morozov

  committed
  2b2848e

  Copy full SHA for 2b2848e

• Reworked type-based and conditions and clarified some types to justify the ones that remain unchanged.

  morozov

  committed
  4edcd15

  Copy full SHA for 4edcd15

• Fixed dynamic calls to static methods

  morozov

  committed
  300a8e5

  Copy full SHA for 300a8e5

• Use the original case in method calls

  morozov

  committed
  8e4946a

  Copy full SHA for 8e4946a

• Reworked usages of the short ternary operator

  morozov

  committed
  f30a9a9

  Copy full SHA for f30a9a9

• Reworked all possible usages of the empty() construct and whitelisted the rest

  morozov

  committed
  6c4401f

  Copy full SHA for 6c4401f

• Avoid implicit conversion to boolean

  morozov

  committed
  7336ae0

  Copy full SHA for 7336ae0

• Suppressed variable property access error in statement classes

  morozov

  committed
  182d3d8

  Copy full SHA for 182d3d8

• Use in_array() in strict mode

  morozov

  committed
  24fc969

  Copy full SHA for 24fc969

• Use array_search() in strict mode

  morozov

  committed
  8b0ddf6

  Copy full SHA for 8b0ddf6

• Anonymous function should have native return typehint

  morozov

  committed
  e17fcab

  Copy full SHA for e17fcab

• Foreach overwrites $variable with its value variable.

  morozov

  committed
  2b3b718

  Copy full SHA for 2b3b718

• Use base64_decode() in strict mode

  morozov

  committed
  e676578

  Copy full SHA for e676578

• Variable method call on an object

  morozov

  committed
  20c5931

  Copy full SHA for 20c5931

• Reworked implicit array creation

  morozov

  committed
  7acf85c

  Copy full SHA for 7acf85c

• Fixed return values types to match the parent method types

  morozov

  committed
  d45fd7a

  Copy full SHA for d45fd7a

• Removed redundant casting to string

  morozov

  committed
  0a57e8e

  Copy full SHA for 0a57e8e

• Only numeric types are allowed in +/-

  morozov

  committed
  559c6ba

  Copy full SHA for 559c6ba

• Declared Driver\Statement::bind(Parameter|Value) $name argument as string|ing

  morozov

  committed
  b8066db

  Copy full SHA for b8066db