Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the hard-coded MySQL default port and the usage of ini-settings #3933

Merged
merged 1 commit into from
Apr 8, 2020

Conversation

morozov
Copy link
Member

@morozov morozov commented Apr 7, 2020

Q A
Type improvement
BC Break no

There's no need to use the hard-coded MySQL port 3306 in the DBALs codebase. There's also no need to manually pass the value obtainer from ini_get('mysqli.default_port') to the driver. The driver doesn't require a port and is aware of the default port:

<?php declare(strict_types=1);

$conn = mysqli_init();
$conn->real_connect('localhost', 'root');
var_dump($conn->query('SELECT VERSION()')->fetch_row());

/*array(1) {
  [0] =>
  string(6) "5.7.27"
}*/

@morozov morozov mentioned this pull request Apr 7, 2020
4 tasks
@morozov morozov force-pushed the remove-mysqli-default-port branch from 1c72d14 to 8568ca6 Compare April 7, 2020 20:58
@morozov morozov added this to the 3.0.0 milestone Apr 8, 2020
@morozov morozov merged commit 66f0577 into doctrine:3.0.x Apr 8, 2020
@morozov morozov deleted the remove-mysqli-default-port branch April 8, 2020 18:31
@morozov morozov self-assigned this Apr 8, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants