Fix deprecation ignore by link

[janlanger]

Initial value in ignoredLinks must be set to 1, same as https://github.com/doctrine/deprecations/blob/master/lib/Doctrine/Deprecations/Deprecation.php#L143 Otherwise the error is not ignored.

[greg0ire]

🤔 if the deprecation is ignored, why is it taken into account in the count?

[janlanger]

It's the same test as the ane above for ignore by package. I don't know the reason behind this.

[greg0ire]

This test does not make sense to me, and in fact, the existing code makes no sense to me either.

deprecations/lib/Doctrine/Deprecations/Deprecation.php

Lines 55 to 59 in ebe09b4

	/** @var array<string,bool> */
	private static $ignoredPackages = [];
	/** @var array<string,int> */
	private static $ignoredLinks = [];

Why is ignoredLinks a hash of counters instead of a hash of booleans?

[derrabus]

Closing because the PR is stalling. Feel free to open a new one if you want to resume the work.

[janlanger]

@derrabus There is nothing to work on, the PR is ready to be reviewed and merged

[derrabus]

All right, reopening then. It's just that you had not answered @greg0ire's question until a couple of minutes ago.

But I must admit, I don't understand your change and the test confuses me even more.

[greg0ire]

But I must admit, I don't understand your change and the test confuses me even more.

For me it's not really the test that I don't understand, it's the pre-existing code 😅

It feels like ignoreLinks should be a hash of booleans, and that there should be another property perhaps named triggeredDeprecations which would be a hash of counters. @beberlei , maybe you can help with this?

[janlanger]

It's just that you had not answered @greg0ire's question until a couple of minutes ago.

But I must admit, I don't understand your change and the test confuses me even more.

Well, yes, because the question is about pre-existing code and not the change :-) I've just fixed obvious bug, based on the $ignoredLinks usage elsewhere, and adapted test from existing one. I cannot answer previous architecture choices...

[derrabus]

All right. Can you produce a green test suite?

[ruudk]

@derrabus @greg0ire I applied the above feedback in #43

[stof]

Closing in favor of #43