DDC-3336 - undefined property with paginator walker and scalar expression in ORDER BY clause #1210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… BY` clause crash the `LimitSubqueryOutputWalker`
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DDC-3433 We use Jira to track the state of pull requests and the versions they got |
|
Needs to also be merged back into the |
|
Requires an additional test about hidden properties as well. |
guilhermeblanco
added a commit
that referenced
this pull request
Dec 5, 2014
…erty-with-paginator-and-scalar-expression-select DDC-3336 - undefined property with paginator walker and scalar expression in ORDER BY clause
Ocramius
deleted the
hotfix/DDC-3336-undefined-property-with-paginator-and-scalar-expression-select
branch
Ocramius
added a commit
that referenced
this pull request
Dec 5, 2014
…r-walkers-with-scalar-expressions-in-order-by-clause' into 2.4 Close #1210
|
@Ocramius this probably also needs merging into the 2.5 branch (master is now 2.6) |
|
Ah, scratch that: I'll probably kill the |
|
@Ocramius yeah, makes sense. |
This was referenced Dec 6, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ping @glen-84
Fixes DDC-3336 - http://www.doctrine-project.org/jira/browse/DDC-3336