Add Phpstan to CI #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
suggested changes
Sep 19, 2017
| @@ -37,6 +37,7 @@ class SerializableArrayObjectAsset extends ArrayObject implements Serializable | |||
| */ | |||
| public function __construct() | |||
| { | |||
| parent::__construct(); | |||
There was a problem hiding this comment.
couldn't see a quick way to disable a single rule....
maybe i'm not groking the phpstan well enough
There was a problem hiding this comment.
hmm, just have to use ignoreMessages?
| @@ -39,6 +39,7 @@ class PharExceptionAsset extends PharException | |||
| */ | |||
| public function __construct() | |||
| { | |||
| parent::__construct(); | |||
| @@ -36,6 +36,7 @@ class PharAsset extends Phar | |||
| */ | |||
| public function __construct() | |||
| { | |||
| parent::__construct('foo'); | |||
| @@ -36,6 +36,7 @@ | |||
| */ | |||
| public function __construct() | |||
| { | |||
| parent::__construct(); | |||
| @@ -36,6 +36,7 @@ class ExceptionAsset extends Exception | |||
| */ | |||
| public function __construct() | |||
| { | |||
| parent::__construct(); | |||
| @@ -36,6 +36,7 @@ class ArrayObjectAsset extends ArrayObject | |||
| */ | |||
| public function __construct() | |||
| { | |||
| parent::__construct(); | |||
.travis.yml
Outdated
| script: ./vendor/bin/phpcs --standard=PSR2 ./src/ ./tests/ | ||
| install: composer require "squizlabs/php_codesniffer:^3.0.2" "phpstan/phpstan:^0.9" --dev | ||
| script: | ||
| - ./vendor/bin/phpcs --standard=PSR2 ./src/ ./tests/ |
There was a problem hiding this comment.
Split these tools into separate steps: once is CS, the other is static analysis
bendavies
force-pushed
the
phpstan
branch
2 times, most recently
from
4781cec to
6369882
Compare
|
@Ocramius done |
|
Thanks @bendavies! |
|
@Ocramius think you forgot to hit merge :) |
|
Whoops! |
|
I wouldn't personally go with max (L7), it has some issues with union types etc., thus 5, maybe 6 at most. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thoughts on level
max?Pretty small library, so not hard to make it pass on max.