allow custom sorting

doctrine · Sep 7, 2019 · 0535cfe · 0535cfe
1 parent 50c7d16
commit 0535cfe
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 3 deletions.
diff --git a/lib/Doctrine/Migrations/Configuration/Configuration.php b/lib/Doctrine/Migrations/Configuration/Configuration.php
@@ -21,6 +21,7 @@
 use Doctrine\Migrations\QueryWriter;
 use Doctrine\Migrations\Version\Version;
 use function str_replace;
+use function strcmp;
 use function strlen;
 
 /**
@@ -88,6 +89,9 @@ class Configuration
     /** @var bool */
     private $checkDbPlatform = true;
 
+    /** @var callable */
+    private $sortingStrategy;
+
     public function __construct(
         Connection $connection,
         ?OutputWriter $outputWriter = null,
@@ -128,6 +132,22 @@ public function getMigrationsTableName() : string
         return $this->migrationsTableName;
     }
 
+    public function setSortingStrategy(callable $sortingStrategy) : void
+    {
+        $this->sortingStrategy = $sortingStrategy;
+    }
+
+    public function getSortingStrategy() : callable
+    {
+        if ($this->sortingStrategy === null) {
+            $this->sortingStrategy = static function (Version $a, Version $b) : int {
+                return strcmp($a->getVersion(), $b->getVersion());
+            };
+        }
+
+        return $this->sortingStrategy;
+    }
+
     public function setMigrationsColumnName(string $columnName) : void
     {
         $this->migrationsColumnName = $columnName;

diff --git a/lib/Doctrine/Migrations/MigrationRepository.php b/lib/Doctrine/Migrations/MigrationRepository.php
@@ -13,7 +13,6 @@
 use Doctrine\Migrations\Finder\MigrationFinder;
 use Doctrine\Migrations\Version\Factory;
 use Doctrine\Migrations\Version\Version;
-use const SORT_STRING;
 use function array_diff;
 use function array_keys;
 use function array_map;
@@ -25,9 +24,9 @@
 use function get_class;
 use function implode;
 use function is_array;
-use function ksort;
 use function sprintf;
 use function substr;
+use function uasort;
 
 /**
  * The MigrationRepository class is responsible for retrieving migrations, determing what the current migration
@@ -85,7 +84,7 @@ public function addVersion(Version $version) : void
     {
         $this->versions[$version->getVersion()] = $version;
 
-        ksort($this->versions, SORT_STRING);
+        uasort($this->versions, $this->configuration->getSortingStrategy());
     }
 
     /**