ensure there is always some metadata configuration set

doctrine · Nov 30, 2019 · 5a09688 · 5a09688
1 parent 4626cbd
commit 5a09688
Show file tree

Hide file tree

Showing 6 changed files with 52 additions and 0 deletions.
diff --git a/lib/Doctrine/Migrations/Configuration/Loader/ArrayLoader.php b/lib/Doctrine/Migrations/Configuration/Loader/ArrayLoader.php
@@ -65,6 +65,10 @@ public function load($array) : Configuration
         $object = new Configuration();
         self::applyConfigs($configMap, $object, $array);
 
+        if ($object->getMetadataStorageConfiguration() === null) {
+            $object->setMetadataStorageConfiguration(new TableMetadataStorageConfiguration());
+        }
+
         return $object;
     }
 

diff --git a/tests/Doctrine/Migrations/Tests/Configuration/Loader/AbstractLoaderTest.php b/tests/Doctrine/Migrations/Tests/Configuration/Loader/AbstractLoaderTest.php
@@ -36,6 +36,25 @@ public function testLoad() : void
         self::assertSame('doctrine_migration_executed_at_column_test', $storage->getExecutedAtColumnName());
     }
 
+    public function testLoadBasic() : void
+    {
+        $config = $this->load('basic');
+
+        self::assertNull($config->getName());
+        self::assertSame(['DoctrineMigrationsTest' => dirname(__DIR__) . DIRECTORY_SEPARATOR . '_files'], $config->getMigrationDirectories());
+
+        self::assertSame([], $config->getMigrationClasses());
+
+        $storage = $config->getMetadataStorageConfiguration();
+        self::assertInstanceOf(TableMetadataStorageConfiguration::class, $storage);
+
+        self::assertSame('doctrine_migration_versions', $storage->getTableName());
+        self::assertSame('version', $storage->getVersionColumnName());
+        self::assertSame(1024, $storage->getVersionColumnLength());
+        self::assertSame('execution_time', $storage->getExecutionTimeColumnName());
+        self::assertSame('executed_at', $storage->getExecutedAtColumnName());
+    }
+
     public function testConfigurationFileNotExists() : void
     {
         $this->expectException(InvalidArgumentException::class);

diff --git a/tests/Doctrine/Migrations/Tests/Configuration/_files/config_basic.json b/tests/Doctrine/Migrations/Tests/Configuration/_files/config_basic.json
@@ -0,0 +1,5 @@
+{
+    "migrations_paths" : {
+        "DoctrineMigrationsTest": "."
+    }
+}
diff --git a/tests/Doctrine/Migrations/Tests/Configuration/_files/config_basic.php b/tests/Doctrine/Migrations/Tests/Configuration/_files/config_basic.php
@@ -0,0 +1,7 @@
+<?php
+
+declare(strict_types=1);
+
+return [
+    'migrations_paths'      => ['DoctrineMigrationsTest' => '.'],
+];
diff --git a/tests/Doctrine/Migrations/Tests/Configuration/_files/config_basic.xml b/tests/Doctrine/Migrations/Tests/Configuration/_files/config_basic.xml
@@ -0,0 +1,12 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<doctrine-migrations xmlns="http://doctrine-project.org/schemas/migrations/configuration/3.0"
+                     xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+                     xsi:schemaLocation="http://doctrine-project.org/schemas/migrations/configuration/3.0
+                    http://doctrine-project.org/schemas/migrations/configuration/3.0.xsd">
+<migrations-paths>
+    <path namespace="DoctrineMigrationsTest">.</path>
+</migrations-paths>
+
+</doctrine-migrations>
+
+
diff --git a/tests/Doctrine/Migrations/Tests/Configuration/_files/config_basic.yml b/tests/Doctrine/Migrations/Tests/Configuration/_files/config_basic.yml
@@ -0,0 +1,5 @@
+---
+migrations_paths:
+  DoctrineMigrationsTest: .
+
+