Prevent the use of 0 as migration name as it is used internally and c…

…onflict
doctrine · Oct 17, 2015 · 5df49c5 · 5df49c5
1 parent bac31ab
commit 5df49c5
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 1 deletion.
diff --git a/lib/Doctrine/DBAL/Migrations/Finder/AbstractFinder.php b/lib/Doctrine/DBAL/Migrations/Finder/AbstractFinder.php
@@ -56,7 +56,14 @@ protected function loadMigrations($files, $namespace)
         foreach ($files as $file) {
             static::requireOnce($file);
             $className = basename($file, '.php');
-            $version = substr($className, 7);
+            $version = (string) substr($className, 7);
+            if ($version === '0') {
+                throw new \InvalidArgumentException(sprintf(
+                    'Cannot load a migrations with the name "%s" because it is a reserved number by doctrine migraitons' . PHP_EOL .
+                    'It\'s used to revert all migrations including the first one.',
+                    $version
+                ));
+            }
             $migrations[$version] = sprintf('%s\\%s', $namespace, $className);
         }
 

diff --git a/tests/Doctrine/DBAL/Migrations/Tests/Finder/RecursiveRegexFinderTest.php b/tests/Doctrine/DBAL/Migrations/Tests/Finder/RecursiveRegexFinderTest.php
@@ -26,6 +26,14 @@ class RecursiveRegexFinderTest extends MigrationTestCase
 {
     private $finder;
 
+    /**
+     * @expectedException InvalidArgumentException
+     */
+    public function testVersionNameCausesErrorWhen0()
+    {
+        $this->finder->findMigrations(__DIR__.'/_regression/NoVersionNamed0');
+    }
+
     /**
      * @expectedException InvalidArgumentException
      */

diff --git a/tests/Doctrine/DBAL/Migrations/Tests/Finder/_regression/NoVersionNamed0/Version0.php b/tests/Doctrine/DBAL/Migrations/Tests/Finder/_regression/NoVersionNamed0/Version0.php