-
-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Usability improvements for migrations with addSql and parameters #186
Comments
Can you send a PR addign a link to the DBAL documentation in the relevant place ? |
+1 on the "By including them in the output of --dry-run" comment |
@gbirke @metalmini |
I think that adding them in the output of --dry-run means:
but rather
But there will be problems with big parameters array. (With long text, binary value) |
@aaa2000 Well I would accept both the PR on the doc and the dry run improvements. |
The
addSql
method accepts parameters for creating inserting in a query. This is very useful for data migrations. However, the usability could be improved:By adding an example to the docs that uses placeholders and a parameters array (or links to http://docs.doctrine-project.org/projects/doctrine-dbal/en/latest/reference/data-retrieval-and-manipulation.html where the placeholder syntax is explained)
By including them in the output of
--dry-run
The text was updated successfully, but these errors were encountered: