Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add badges into README about license and packagist #1020

Merged
merged 1 commit into from
Jun 22, 2020

Conversation

matks
Copy link
Contributor

@matks matks commented Jun 21, 2020

Q A
Type improvement
BC Break no
Fixed issues

Summary

This PR adds multiple badges into the README. Badges are provided by http://shields.io/ and rely on data sources provided by GitHub and Packagist

Badges are really beautiful 🤩 but also can provide useful informations for people quickly browsing GitHub repositories.

@greg0ire
Copy link
Member

Let's retarget this to the lowest maintained branch in case we change the default branch

@greg0ire greg0ire changed the base branch from master to 2.3.x June 21, 2020 20:13
README.md Show resolved Hide resolved
@greg0ire greg0ire closed this Jun 21, 2020
@greg0ire greg0ire reopened this Jun 21, 2020
@matks
Copy link
Contributor Author

matks commented Jun 21, 2020

Let's retarget this to the lowest maintained branch in case we change the default branch

I think I can guess what discussion this is about 😛 however FYI this link is private, I cant see it 😄 it's probably for maintainers only

@matks
Copy link
Contributor Author

matks commented Jun 21, 2020

Thank you for

  • very fast answer
  • doing the retarget + rebase yourself (I could have done it if you asked me to 😉 )

Amazing work you're doing it here, on Sunday evening ❤️

@greg0ire
Copy link
Member

I think I can guess what discussion this is about stuck_out_tongue however FYI this link is private, I cant see it smile it's probably for maintainers only

Oh indeed, sorry, I will know better from now on!

@greg0ire greg0ire requested a review from goetas June 21, 2020 20:49
@goetas goetas merged commit 4543168 into doctrine:2.3.x Jun 22, 2020
@goetas goetas added this to the 2.3.0 milestone Jun 22, 2020
@matks matks deleted the readme-badges branch June 22, 2020 09:39
goetas added a commit that referenced this pull request Nov 22, 2020
- Total issues resolved: **0**
- Total pull requests resolved: **6**
- Total contributors: **6**

 - [1032: Let composer decide the best version](#1032) thanks to @PowerKiKi

 - [1020: Add badges into README about license and packagist](#1020) thanks to @matks
 - [999: Allow using on PHP 7.1 with Composer 2](#999) thanks to @nicolas-grekas

 - [981: Add "from-empty-schema" option for "diff" command](#981) thanks to @guilliamxavier
 - [954: Make compared tables order idempotent](#954) thanks to @julienfalque

 - [888: Use executeUpdate instead of executeQuery for write operation](#888) thanks to @goetas
goetas added a commit that referenced this pull request Nov 22, 2020
- Total issues resolved: **0**
- Total pull requests resolved: **6**
- Total contributors: **6**

 - [1032: Let composer decide the best version](#1032) thanks to @PowerKiKi

 - [1020: Add badges into README about license and packagist](#1020) thanks to @matks
 - [999: Allow using on PHP 7.1 with Composer 2](#999) thanks to @nicolas-grekas

 - [981: Add "from-empty-schema" option for "diff" command](#981) thanks to @guilliamxavier
 - [954: Make compared tables order idempotent](#954) thanks to @julienfalque

 - [888: Use executeUpdate instead of executeQuery for write operation](#888) thanks to @goetas
goetas added a commit that referenced this pull request Nov 22, 2020
- Total issues resolved: **0**
- Total pull requests resolved: **6**
- Total contributors: **6**

 - [1032: Let composer decide the best version](#1032) thanks to @PowerKiKi

 - [1020: Add badges into README about license and packagist](#1020) thanks to @matks
 - [999: Allow using on PHP 7.1 with Composer 2](#999) thanks to @nicolas-grekas

 - [981: Add "from-empty-schema" option for "diff" command](#981) thanks to @guilliamxavier
 - [954: Make compared tables order idempotent](#954) thanks to @julienfalque

 - [888: Use executeUpdate instead of executeQuery for write operation](#888) thanks to @goetas
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants