Set dependencyFactory before configure is called in DoctrineCommand

[jkrzefski]

Q	A
Type	bug
BC Break	no
Fixed issues

Summary

While reading through the code I found this piece here and I figured, it would never actually do anything with the way things are set up. The constructor always sets the value for $dependencyFactory only after calling its parent, so until then $dependencyFactory is considered null. The parent's constructor in turn calls the configure method which checks if $dependencyFactory is null.

I have switched the assignment of $dependencyFactory with the call to the parent's constructor, so that the condition in the configure method actually does something depending on the presence of a $dependencyFactory.

I consider this a breaking change, since this can potentially lead to one less input option for a doctrine command, thus changing the command definition and breaking scripts that provide this option.

[greg0ire]

Nice find! Can you please add a test here: https://github.com/doctrine/migrations/blob/3.0.x/tests/Doctrine/Migrations/Tests/Tools/Console/Command/DoctrineCommandTest.php ?

[jkrzefski]

@greg0ire I added a test case and made sure it fails without my change. Please take a look at it. And thank you for your patience.

[greg0ire]

Please kindly squash your commits together. If you don't, we'll try to remember to do it for you but it's best if you save us this trouble.

How to do that?

1. git rebase -i origin/3.0.x, assuming origin is a git remote that points to this repository, and not your fork. If you're not sure what your remotes are, run git remote -vvv, there should be your fork and the holy/reference/base/origin/whatever-you-call-it repository.
2. A window will show up with many lines, replace pick with fixup on every line but the first one
3. Close your editor, git should do its magic, and you should end up with one commit
4. Use git push --force to overwrite what you already push. Don't forget the --force option otherwise git will try to merge both things together.

[jkrzefski]

Rebased and squashed.

[goetas]

@SenseException I have rebased it and added the db-configuration check.

[goetas]

@SenseException makes sense! code updated

[goetas]

thanks everyone!