Do not pass connection name to PrimaryReadReplicaConnection::connect()
#1156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankverhoeven
force-pushed
the
primary-read-replica-connection-connect
branch
from
6c9aebc to
b4892f6
Compare
stof
requested changes
Apr 28, 2021
| @@ -198,7 +198,7 @@ private function isInitialized(): bool | |||
| } | |||
|
|
|||
| if ($this->connection instanceof PrimaryReadReplicaConnection) { | |||
| $this->connection->connect('master'); | |||
| $this->connection->connect(); | |||
There was a problem hiding this comment.
The equivalent of the old ->connect('master') API of MasterSlaveConnection is ->ensureConnectedToPrimary(), not ->connect()
stof
approved these changes
Apr 28, 2021
SenseException
approved these changes
Apr 29, 2021
|
Should this target 2.3.x, or does the fix not apply there? |
|
@greg0ire no. 2.3.x is not affected. It properly uses the new API for the new version of DBAL already (but |
|
Let's merge this then! Thanks @frankverhoeven ! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Passing a connection name to
PrimaryReadReplicaConnection::connect()will result in an exception being thrown.This change will remove the
mastername fromTableMetadataStorage::isInitialized()to prevent that exception.