Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct default values for VersionColumnLength in doc #1293

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

eigan
Copy link
Contributor

@eigan eigan commented Dec 12, 2022

See TableMetadataStorageConfiguration

Relevant
#960 (from 1024 -> 191)

Q A
Type bug (documentation)
BC Break no
Fixed issues

Summary

The documentation references 1024 as default version column length, but the actual default value is 191. https://github.com/doctrine/migrations/blob/5713b45c933122e509d9b31c767b420c3dfed399/lib/Doctrine/Migrations/Metadata/Storage/TableMetadataStorageConfiguration.php

See TableMetadataStorageConfiguration
@SenseException SenseException merged commit 4eeb796 into doctrine:3.5.x Dec 12, 2022
@SenseException
Copy link
Member

Thank you @eigan

@greg0ire greg0ire added this to the 3.5.3 milestone Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants