Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attributes to commands #1330

Merged

Conversation

gordinskiy
Copy link
Contributor

Q A
Type improvement
BC Break no
Fixed issues #1329

Add usage of Symfony\Component\Console\Attribute\AsCommand attributes

@derrabus
Copy link
Member

Thank you. Can you please also add the description: parameter to all attributes?

@gordinskiy gordinskiy force-pushed the issue-1329-fix-command-deprecations branch from 22b283c to f28ed89 Compare March 13, 2023 18:53
@derrabus derrabus added this to the 3.6.1 milestone Mar 13, 2023
@pkruithof
Copy link

@derrabus any progress on this?

@greg0ire
Copy link
Member

The backward compat check can be ignored, but the static analysis check should get fixed before this can be merged.

@gordinskiy
Copy link
Contributor Author

gordinskiy commented Aug 18, 2023

Ignored error pattern ^Call to function method_exists() with Doctrine\Migrations\Metadata\Storage\MetadataStorage and 'getSql' will always evaluate to true.$ in path /home/runner/work/migrations/migrations/lib/Doctrine/Migrations/Version/DbalExecutor.php was not matched in reported errors.

How to fix this error correctly?
Remove the check, and move the method from the annotation to the interface itself?

@greg0ire
Copy link
Member

Rebasing might be enough: it does not seem to come from your changes. I'll try closing and reopening in case that does the trick.

@greg0ire greg0ire closed this Aug 18, 2023
@greg0ire greg0ire reopened this Aug 18, 2023
@greg0ire greg0ire merged commit 1f140dd into doctrine:3.6.x Aug 18, 2023
@greg0ire
Copy link
Member

Thanks @gordinskiy !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants