Enhancement: Allow to set OutputWriter #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
localheinz
force-pushed
the
feature/allow-to-set-output-writer
branch
3 times, most recently
from
bf324bb to
167d3db
Compare
localheinz
force-pushed
the
feature/allow-to-set-output-writer
branch
from
8676e84 to
df29f93
Compare
mikeSimonson
added a commit
that referenced
this pull request
Aug 18, 2015
…riter Enhancement: Allow to set OutputWriter
|
Thank you, @mikeSimonson! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
OutputWritercan be injected via constructorOutputWriteris created otherwiseOutputWritercan be injected via mutatorUse Case
When fetching a migration configuration from a container, you don't have an
OutputWriteryet, you don't even have anOutputyet (you may not even need it). So, wiring up bothOutputWriterandOutputin the container seems like overkill.Being able to set the
OutputWriter, however, when you need it, would be nice.