Allow overriding of the Migration template #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Retrieving the template through a method instead of accessing the private variable directly enables the extension of the "Generate" command.
mikeSimonson
added a commit
that referenced
this pull request
Dec 16, 2015
…template Allow overriding of the Migration template
|
@jeromegamez Thanks. For the record we hope to make that easier for you for the next version of doctrine migrations. |
|
That was quick, thank you! ❤️ |
|
no problems |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retrieving the template through a method instead of accessing the private variable directly enables the extension of the "Generate" command.
As an example: in kreait/ezpublish-migrations-bundle, I have created a custom Migration class and a custom generate command, so that a Version can perform needed actions automatically and provide helper methods.
At the moment, it would be necessary to duplicate the
generateMigrationmethod.With the change from this PR, someone extending the
GenerateCommandwould just have to override thegetTemplatemethod.